chore: handle (re)subscribe in guide toolbar V2 when entering/exiting

[thomaswhyyou]

Description

** Describe what, why and how of the changes clearly and concisely. Add any additional useful context or info, as necessary. **

Todos

** List any todo items necessary before merging, if any. Delete if none. **

• Sample todo item 1
• Sample todo item 2

Checklist

• Tests have been added for new features or major refactors to existing features.

Screenshots or videos

** Attach any screenshots or recordings to visually illustrate the changes, as necessary. Delete if not relevant. **

[linear]

KNO-12539 [Toolbar] Fix not authenticated error in new SDK version toolbar

[changeset-bot]

⚠️ No Changeset found

Latest commit: 63df698

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
javascript-ms-teams-connect-example	Ready	Preview, Comment	Apr 9, 2026 8:21pm
javascript-nextjs-example	Ready	Preview, Comment	Apr 9, 2026 8:21pm
javascript-slack-connect-example	Ready	Preview, Comment	Apr 9, 2026 8:21pm
javascript-slack-kit-example	Ready	Preview, Comment	Apr 9, 2026 8:21pm

[thomaswhyyou]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore: handle (re)subscribe in guide toolbar V2 when entering/exiting #943 👈 (View in Graphite)
• fix: coordinate the first fetch in guide toolbar v2 and guide client via readyToTarget #942
• chore: remove localStorage persistence of toolbar debug config #941
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

[thomaswhyyou]

@cursor review

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ab5fe31. Configure here.}

[cursor]

Cleanup unconditionally calls stopDebug causing spurious side effects

Medium Severity

The cleanup function unconditionally calls stopDebug(), which always invokes client.unsetDebug() and client.subscribe()/client.unsubscribe(), even when the toolbar was never visible and debug mode was never entered. Since the V2 component is always rendered (returns null when not visible, but hooks still run), any change to readyToTarget or listenForUpdates triggers this cleanup. When listenForUpdates is true, the spurious subscribe() call disconnects and reconnects the websocket channel unnecessarily. Additionally, subscribe() calls this.knock.failIfNotAuthenticated() which throws if the user is unauthenticated — unlike the old code in setDebug/unsetDebug that guarded against this. During logout/unmount, this cleanup can throw an unhandled error. The cleanup needs a guard to only call stopDebug() when debug mode was actually entered.

Additional Locations (1)

• packages/react/src/modules/guide/components/Toolbar/V2/V2.tsx#L115-L119

 

^{Reviewed by Cursor Bugbot for commit ab5fe31. Configure here.}