chore: remove localStorage persistence of toolbar debug config#941
Merged
thomaswhyyou merged 2 commits intomainfrom Apr 9, 2026
Conversation
🦋 Changeset detectedLatest commit: 8e1801d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a2445bd. Configure here.
thomaswhyyou
changed the title
thomaswhyyou
force-pushed
the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version
branch
from
43246dc to
9afa1e6
Compare
thomaswhyyou
force-pushed
the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version
branch
from
9afa1e6 to
8e1801d
Compare
thomaswhyyou
requested review from
a team,
connorlindsey and
kylemcd
and removed request for
a team
cjbell
approved these changes
Apr 9, 2026
thomaswhyyou
deleted the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version
branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 64.00% 63.91% -0.10%
==========================================
Files 209 209
Lines 10021 9990 -31
Branches 1288 1277 -11
==========================================
- Hits 6414 6385 -29
+ Misses 3582 3580 -2
Partials 25 25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes local storage persistence of guide toolbar v2 run configs. This is something we had with the original toolbar v1 which we replicated, but tbh it doesn't really add that much for toolbar v2 and it complicates the debug start/stop state handling.
It's easy enough to bring it back if needed in the future, and I'd like to simplify this to make things easier for the coordination between the guide client and guide toolbar in the subsequent PR: #942