fix: coordinate the first fetch in guide toolbar v2 and guide client via readyToTarget#942
Merged
thomaswhyyou merged 4 commits intomainfrom Apr 9, 2026
Conversation
🦋 Changeset detectedLatest commit: 43c0e12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 9, 2026
thomaswhyyou
changed the title
Contributor
Author
|
@cursor review |
thomaswhyyou
force-pushed
the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version-2
branch
from
bdda172 to
0489df2
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bdda172. Configure here.
thomaswhyyou
force-pushed
the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version
branch
from
43246dc to
9afa1e6
Compare
thomaswhyyou
force-pushed
the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version-2
branch
from
0489df2 to
deae866
Compare
thomaswhyyou
force-pushed
the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version
branch
from
9afa1e6 to
8e1801d
Compare
thomaswhyyou
force-pushed
the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version-2
branch
from
deae866 to
7e4dc86
Compare
thomaswhyyou
commented
Apr 9, 2026
| `[Guide] Stop debugging, refetching guides and resubscribing to the websocket channel`, | ||
| ); | ||
| this.fetch({ force: true }); | ||
| // TODO: Manage (re)subscribe/unsubscribe in V2 rather than here. |
| }, predicateDefault); | ||
| }; | ||
|
|
||
| // Use this param to start Toolbar v2 and enter into a debugging session when |
Contributor
Author
There was a problem hiding this comment.
Just moved, not new.
| const { isVisible = false, focusedGuideKeys = {} } = runConfig || {}; | ||
| const isDebugging = client.store.state.debug?.debugging; | ||
| if (isVisible && !isDebugging) { | ||
| if (isVisible && !isDebugging && readyToTarget) { |
Contributor
Author
There was a problem hiding this comment.
This is the main change: We check if readyToTarget is true before making the fetch call.
thomaswhyyou
requested review from
a team,
MikeCarbone,
connorlindsey and
meryldakin
and removed request for
a team
cjbell
approved these changes
Apr 9, 2026
Base automatically changed from
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version
to
main
April 9, 2026 20:19
thomaswhyyou
force-pushed
the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version-2
branch
from
7e4dc86 to
43c0e12
Compare
thomaswhyyou
deleted the
thomas-kno-12539-toolbar-fix-not-authenticated-error-in-new-sdk-version-2
branch
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 63.91% 63.85% -0.06%
==========================================
Files 209 209
Lines 9990 10007 +17
Branches 1277 1281 +4
==========================================
+ Hits 6385 6390 +5
- Misses 3580 3592 +12
Partials 25 25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to address the issue Webflow flagged (here), where the guide toolbar v2 immediately tries to fetch guides upon mounting but results in an error due to not having been authenticated, because Webflow fetches and passes user id to the knock client asynchronously which then authenticates.
KnockGuideProvideralready provides thereadyToTargetprop for controlling when the guide client fires a request to fetch guides. In this PR the toolbar now receives thereadyToTargetprop also so it can control and coordinate the fetch call.