refactor(config): remove 14 USAConfig flags and delete obsolete YAMLs#294
Draft
briantobin-99 wants to merge 1 commit intobtobin__cleanup-epa-diagnosticsfrom
Draft
refactor(config): remove 14 USAConfig flags and delete obsolete YAMLs#294briantobin-99 wants to merge 1 commit intobtobin__cleanup-epa-diagnosticsfrom
briantobin-99 wants to merge 1 commit intobtobin__cleanup-epa-diagnosticsfrom
Conversation
Remove 14 boolean/literal feature flags from USAConfig that are no longer needed now that the Cornerstone path is hardcoded. Delete 15 obsolete per-flag config YAML files. Update remaining YAMLs to remove references to deleted flags. Retain scale_a_matrix_with_* flags (3) as experimental. Add test_config_cleanup.py to verify removed flags are gone and retained flags are present.
This was referenced Mar 20, 2026
Contributor
Author
Stack
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc:
Closes:
What changed? Why?
Remove 14 boolean/literal feature flags from
USAConfiginbedrock/utils/config/usa_config.py:use_cornerstone_2026_model_schema,load_E_from_flowsa,new_ghg_method,use_E_data_year_for_x_in_B,implement_waste_disaggregation,usa_ghg_methodology, and all 9 individual GHG method flags. Delete 15 obsolete per-flag config YAML files frombedrock/utils/config/configs/. Update remaining YAMLs (v8_ceda_2025_usa.yaml,test_usa_config.yaml,test_usa_config_waste_disagg.yaml,2025_usa_cornerstone_full_model.yaml) to remove references to deleted flags. Retainscale_a_matrix_with_*flags (3) as experimental.Stack: 5/5 — final cleanup, depends on #4 (EPA/diagnostics). All code references to deleted flags are already removed in branches 1-4.
Testing
Added
test_config_cleanup.pyverifying removed flags are gone, retained flags are present, default config loads correctly, and Cornerstone-only behavior of pipeline functions. Updatedtest_usa_config.py.Made with Cursor