refactor(allocation): remove GHG if/elif chain and simplify E pipeline#290
Draft
briantobin-99 wants to merge 1 commit intomainfrom
Draft
refactor(allocation): remove GHG if/elif chain and simplify E pipeline#290briantobin-99 wants to merge 1 commit intomainfrom
briantobin-99 wants to merge 1 commit intomainfrom
Conversation
Remove the 10-way GHG method selector in load_E_from_flowsa(), always using GHG_national_Cornerstone_2023. Simplify derive_E_usa() to always call load_E_from_flowsa(). Delete dead functions derive_E_usa_by_gas() and derive_E_usa_emissions_sources(). Remove CEDA sector collapse branch, always use Cornerstone schema. Clean up unused imports.
Contributor
Author
Stack
|
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc:
Closes:
What changed? Why?
Remove the 10-way
if/elifGHG method selector inload_E_from_flowsa(), hardcodingGHG_national_Cornerstone_2023as the only method. Simplifyderive_E_usa()to always callload_E_from_flowsa(). Delete dead functionsderive_E_usa_by_gas()andderive_E_usa_emissions_sources(). Remove CEDA v7 sector collapse branch inmap_to_CEDA(), always using Cornerstone schema. Clean up ~10 unused imports inbedrock/transform/allocation/derived.py.Stack: 1/5 — this is the base of the config cleanup stack.
Testing
Existing allocation tests pass. Snapshot comparison pending.
Made with Cursor