fix(epa): fix data year validation and remove diagnostics gating#293
Draft
briantobin-99 wants to merge 1 commit intobtobin__cleanup-waste-disagg-gatingfrom
Draft
fix(epa): fix data year validation and remove diagnostics gating#293briantobin-99 wants to merge 1 commit intobtobin__cleanup-waste-disagg-gatingfrom
briantobin-99 wants to merge 1 commit intobtobin__cleanup-waste-disagg-gatingfrom
Conversation
Fix _get_epa_data_year() to accept 2024 and reject 2022 (bug). Remove 2022 conditional branches from _get_gcs_epa_dir_for_table(). Clean up calculate_ef_diagnostics.py: remove use_cornerstone conditional branches, always run Cornerstone-only diagnostics. Update run_method_diff.py and test_fbs.py to use GHG_national_Cornerstone_2023.
This was referenced Mar 20, 2026
Contributor
Author
Stack
|
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc:
Closes:
What changed? Why?
Fix
_get_epa_data_year()inextract/allocation/epa.pyto accept[2023, 2024]forusa_ghg_data_year(was incorrectly accepting 2022 and rejecting 2024). Removeyear == 2022conditional branches from_get_gcs_epa_dir_for_table(). Clean upcalculate_ef_diagnostics.py: remove alluse_cornerstoneconditional branches, always running Cornerstone-only diagnostics. Updaterun_method_diff.pyandtest_fbs.pyto useGHG_national_Cornerstone_2023.Stack: 4/5 — depends on #3 (waste disagg gating removal).
Testing
Existing EPA and diagnostics tests pass. FBS test methods updated.
Made with Cursor