fix #382: handle 'layers' stored as h5py.Dataset in read_stereo_h5ad#430
Closed
cursor[bot] wants to merge 1 commit intomainfrom
Closed
fix #382: handle 'layers' stored as h5py.Dataset in read_stereo_h5ad#430cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
When reading a stereopy-flavored h5ad file, the 'layers' key may be stored as an h5py.Dataset instead of an h5py.Group. Previously, the code unconditionally called .keys() on f['layers'], which raises AttributeError on Dataset objects. Now we check isinstance(f[k], h5py.Group) first and handle Dataset fallback by reading it directly. Co-authored-by: wanruiwen-genomics-cn <wanruiwen-genomics-cn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When reading a stereopy-flavored h5ad file via
read_h5ad(flavor='stereopy'), thelayerskey may be stored as anh5py.Datasetinstead of anh5py.Group. The existing code unconditionally called.keys()onf['layers'], which raisesAttributeError: 'Dataset' object has no attribute 'keys'.Changes
stereo/io/reader.py: Added anisinstance(f[k], h5py.Group)check before iterating layer keys. Whenlayersis aDataset, it is read directly viah5ad.read_dataset().tests/test_read_stereo_h5ad_layers.py: Added regression tests verifying both Dataset and Group scenarios work correctly.Closes #382