SAM Landbosse and Python Handler Removals#2154
Merged
Conversation
…anges from develop as well
brtietz
added
the
requires help revision
5 tasks
dguittet
reviewed
Mar 20, 2026
Collaborator
dguittet
left a comment
dguittet
left a comment
There was a problem hiding this comment.
This whole directory should be deleted also: https://github.com/NatLabRockies/SAM/tree/develop/deploy/runtime/python
api/api_autogen/export_config.cpp
Outdated
| if (primary_cmod == "wind_landbosse") | ||
| continue; | ||
| // Reviewer - can we delete this? | ||
| //if (primary_cmod == "wind_landbosse") |
dguittet
approved these changes
Mar 20, 2026
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Remove deprecated Python handler and associated compute modules
Corresponding branches and PRs:
SSC PR NatLabRockies/ssc#1375
SAM-private https://github.com/NatLabRockies/SAM-private/pull/143
Unit Test Impact:
Expect SAM tests to pass (may have some excitement due to defaults updates)
Checklist