Skip to content

SSC landbosse and python handler removals#1375

Merged
brtietz merged 2 commits intodevelopfrom
rmrflandbosse
Mar 20, 2026
Merged

SSC landbosse and python handler removals#1375
brtietz merged 2 commits intodevelopfrom
rmrflandbosse

Conversation

@brtietz
Copy link
Copy Markdown
Collaborator

@brtietz brtietz commented Mar 19, 2026

Pull Request Template

Description

Remove ssc code the depended on deprecated Python Handler

Corresponding branches and PRs:

SAM NatLabRockies/SAM#2154
SAM-private https://github.com/NatLabRockies/SAM-private/pull/143

Unit Test Impact:

Removed tests for these compute modules.

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 19, 2026

Pull Request Test Coverage Report for Build 23362208156

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 133 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 58.315%

Files with Coverage Reduction New Missed Lines %
ssc/shared/lib_geothermal.cpp 5 65.99%
ssc/ssc/sscapi.cpp 128 57.91%
Totals Coverage Status
Change from base Build 23343034455: 0.06%
Covered Lines: 74487
Relevant Lines: 127733

💛 - Coveralls

@brtietz brtietz merged commit af536ea into develop Mar 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants