Skip to content

SAM Landbosse and Python Handler Removals #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brtietz merged 6 commits into from
Mar 20, 2026
Merged

SAM Landbosse and Python Handler Removals #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2cbd3e6
Preliminary pull of python handler and landbossee. Many other files s…
brtietz Mar 13, 2026
7b57bde
Remove python handler. Looks like we picked up a few unrelated api ch…
brtietz Mar 16, 2026
37cac74
UI and defaults updates for wind capital costs without bos estimation
brtietz Mar 19, 2026
9e71106
Update hybrids defaults, remove unused cost pages, add warning to ver…
brtietz Mar 19, 2026
b542062
Merge branch 'develop' of https://github.com/NREL/SAM into rmrflandbosse
brtietz Mar 20, 2026
1ba20e3
Remove unused runtime files and commented out code
brtietz Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ set(SAM_SRC src/private.h
src/shadingfactors.cpp src/shadingfactors.h
src/materials.cpp src/materials.h
src/codegenerator.cpp src/codegenerator.h
src/pythonhandler.cpp src/pythonhandler.h
src/combinecases.cpp src/combinecases.h
src/ptesdesignptdialog.cpp src/ptesdesignptdialog.h
src/geotools.cpp src/geotools.h)
Expand Down
5 changes: 0 additions & 5 deletions api/api_autogen/export_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@ void export_files(const std::string& config, std::set<std::string>& processed_cm
for (auto & primary_cmod : primary_cmods){
processed_cmods.insert(util::lower_case(primary_cmod));

if (primary_cmod == "wind_landbosse")
continue;

std::cout << "Exporting for " << config << ": " << primary_cmod << "... ";
// get all the expressions
builder_generator b_gen(&ce);
Expand Down Expand Up @@ -358,7 +355,6 @@ int main(int argc, char *argv[]){

std::string cmods;
for (auto &c : primary_cmods){
if (c == "wind_landbosse") continue;
cmods += ":doc:`../modules/" + format_as_symbol(c) + "`, ";
}
cmods.pop_back();
Expand Down Expand Up @@ -432,7 +428,6 @@ int main(int argc, char *argv[]){
assert(models_file.is_open());

for (auto & it : models_sorted) {
if (it.first == "WindLandbosse") continue;
models_file << it.second;
cmod_toctree.append(" ../modules/");
cmod_toctree.append(it.first);
Expand Down
4 changes: 0 additions & 4 deletions ...untime/defaults/CustomGeneration PVWatts Wind FuelCell Battery Hybrid_Host Developer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,10 +340,7 @@
"env_exposure_loss": 0.0,
"env_icing_loss": 0.21,
"env_loss_total": 2.398195120000002,
"est_bos_cost": 0.0,
"est_turbine_cost": 0.0,
"inflation_rate": 2.5,
"install_type": 0.0,
"om_capacity": [
39.0
],
Expand All @@ -363,7 +360,6 @@
"ops_strategies_loss": 0.0,
"reference_capacity": 100.0,
"reference_number_turbines": 1.0,
"reference_resource_file": "AZ Eastern-Rolling Hills.srw",
"reference_sales_tax_percent": 5.0,
"resource_definition_type": 0.0,
"rows": 1.0,
Expand Down
4 changes: 0 additions & 4 deletions .../runtime/defaults/CustomGeneration PVWatts Wind FuelCell Battery Hybrid_Single Owner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,7 @@
"env_exposure_loss": 0.0,
"env_icing_loss": 0.21,
"env_loss_total": 2.398195120000002,
"est_bos_cost": 0.0,
"est_turbine_cost": 0.0,
"inflation_rate": 2.5,
"install_type": 0.0,
"om_capacity": [
40.0
],
Expand All @@ -374,7 +371,6 @@
"ops_strategies_loss": 0.0,
"reference_capacity": 200000.0,
"reference_number_turbines": 80.0,
"reference_resource_file": "AZ Eastern-Rolling Hills.srw",
"reference_sales_tax_percent": 5.0,
"resource_definition_type": 0.0,
"rows": 1.0,
Expand Down
4 changes: 0 additions & 4 deletions deploy/runtime/defaults/PVWatts Wind Battery Hybrid_Host Developer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,7 @@
"env_exposure_loss": 0.0,
"env_icing_loss": 0.21,
"env_loss_total": 2.398195120000002,
"est_bos_cost": 0.0,
"est_turbine_cost": 0.0,
"inflation_rate": 2.5,
"install_type": 0.0,
"om_capacity": [
39.0
],
Expand All @@ -287,7 +284,6 @@
"ops_strategies_loss": 0.0,
"reference_capacity": 100.0,
"reference_number_turbines": 1.0,
"reference_resource_file": "AZ Eastern-Rolling Hills.srw",
"reference_sales_tax_percent": 5.0,
"resource_definition_type": 0.0,
"rows": 1.0,
Expand Down
4 changes: 0 additions & 4 deletions deploy/runtime/defaults/PVWatts Wind Battery Hybrid_Single Owner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,7 @@
"env_exposure_loss": 0.0,
"env_icing_loss": 0.21,
"env_loss_total": 2.398195120000002,
"est_bos_cost": 0.0,
"est_turbine_cost": 0.0,
"inflation_rate": 2.5,
"install_type": 0.0,
"om_capacity": [
40.0
],
Expand All @@ -298,7 +295,6 @@
"ops_strategies_loss": 0.0,
"reference_capacity": 200000.0,
"reference_number_turbines": 80.0,
"reference_resource_file": "AZ Eastern-Rolling Hills.srw",
"reference_sales_tax_percent": 5.0,
"resource_definition_type": 0.0,
"rows": 1.0,
Expand Down
4 changes: 0 additions & 4 deletions deploy/runtime/defaults/PVWatts Wind FuelCell Battery Hybrid_Host Developer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,7 @@
"env_exposure_loss": 0.0,
"env_icing_loss": 0.21,
"env_loss_total": 2.398195120000002,
"est_bos_cost": 0.0,
"est_turbine_cost": 0.0,
"inflation_rate": 2.5,
"install_type": 0.0,
"om_capacity": [
39.0
],
Expand All @@ -287,7 +284,6 @@
"ops_strategies_loss": 0.0,
"reference_capacity": 100.0,
"reference_number_turbines": 1.0,
"reference_resource_file": "AZ Eastern-Rolling Hills.srw",
"reference_sales_tax_percent": 5.0,
"resource_definition_type": 0.0,
"rows": 1.0,
Expand Down
4 changes: 0 additions & 4 deletions deploy/runtime/defaults/PVWatts Wind FuelCell Battery Hybrid_Single Owner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,7 @@
"env_exposure_loss": 0.0,
"env_icing_loss": 0.21,
"env_loss_total": 2.398195120000002,
"est_bos_cost": 0.0,
"est_turbine_cost": 0.0,
"inflation_rate": 2.5,
"install_type": 0.0,
"om_capacity": [
40.0
],
Expand All @@ -298,7 +295,6 @@
"ops_strategies_loss": 0.0,
"reference_capacity": 200000.0,
"reference_number_turbines": 80.0,
"reference_resource_file": "AZ Eastern-Rolling Hills.srw",
"reference_sales_tax_percent": 5.0,
"resource_definition_type": 0.0,
"rows": 1.0,
Expand Down
4 changes: 0 additions & 4 deletions deploy/runtime/defaults/Photovoltaic Wind Battery Hybrid_Host Developer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3266,10 +3266,7 @@
"env_exposure_loss": 0.0,
"env_icing_loss": 0.21,
"env_loss_total": 2.398195120000002,
"est_bos_cost": 0.0,
"est_turbine_cost": 0.0,
"inflation_rate": 2.5,
"install_type": 0.0,
"om_capacity": [
39.0
],
Expand All @@ -3289,7 +3286,6 @@
"ops_strategies_loss": 0.0,
"reference_capacity": 100.0,
"reference_number_turbines": 1.0,
"reference_resource_file": "AZ Eastern-Rolling Hills.srw",
"reference_sales_tax_percent": 5.0,
"resource_definition_type": 0.0,
"rows": 1.0,
Expand Down
4 changes: 0 additions & 4 deletions deploy/runtime/defaults/Photovoltaic Wind Battery Hybrid_Single Owner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3921,10 +3921,7 @@
"env_exposure_loss": 0.0,
"env_icing_loss": 0.21,
"env_loss_total": 2.398195120000002,
"est_bos_cost": 0.0,
"est_turbine_cost": 0.0,
"inflation_rate": 2.5,
"install_type": 0.0,
"om_capacity": [
40.0
],
Expand All @@ -3944,7 +3941,6 @@
"ops_strategies_loss": 0.0,
"reference_capacity": 200000.0,
"reference_number_turbines": 80.0,
"reference_resource_file": "AZ Eastern-Rolling Hills.srw",
"reference_sales_tax_percent": 5.0,
"resource_definition_type": 0.0,
"rows": 5.0,
Expand Down
Loading
Loading