Skip to content

Only store verified encrypted private shares within Signer #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jferrant wants to merge 2 commits into from
Closed

Only store verified encrypted private shares within Signer #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d99a7b8
Only store verified encrypted private shares within Signer
jferrant Jun 7, 2024
2359205
Fix formatting
jferrant Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/state_machine/signer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,23 +1075,22 @@ impl<SignerType: SignerTrait> Signer<SignerType> {
return Ok(vec![]);
}

self.dkg_private_shares
.insert(src_signer_id, dkg_private_shares.clone());

// make a HashSet of our key_ids so we can quickly query them
let key_ids: HashSet<u32> = self.signer.get_key_ids().into_iter().collect();

let shared_key = self.kex_private_key * kex_public_key;
let shared_secret = make_shared_secret(&self.kex_private_key, &kex_public_key);

let mut verified_shares = Vec::with_capacity(dkg_private_shares.shares.len());
for (src_id, shares) in &dkg_private_shares.shares {
let mut decrypted_shares = HashMap::new();
let mut encrypted_shares = HashMap::new();
for (dst_key_id, bytes) in shares {
if key_ids.contains(dst_key_id) {
match decrypt(&shared_secret, bytes) {
Ok(plain) => match Scalar::try_from(&plain[..]) {
Ok(s) => {
decrypted_shares.insert(*dst_key_id, s);
encrypted_shares.insert(*dst_key_id, bytes.clone());
}
Err(e) => {
warn!("Failed to parse Scalar for dkg private share from src_id {src_id} to dst_id {dst_key_id}: {e:?}");
Expand All @@ -1114,7 +1113,16 @@ impl<SignerType: SignerTrait> Signer<SignerType> {
self.decrypted_shares.insert(*src_id, decrypted_shares);
self.decryption_keys
.insert(*src_id, (dkg_private_shares.signer_id, shared_key));
verified_shares.push((*src_id, encrypted_shares));
Copy link
Copy Markdown
Collaborator Author

@jferrant jferrant Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could result in empty encrypted shares hashmap per src_id. I assumed this was okay. but just confirming?

}
self.dkg_private_shares.insert(
src_signer_id,
DkgPrivateShares {
dkg_id: dkg_private_shares.dkg_id,
signer_id: dkg_private_shares.signer_id,
shares: verified_shares,
},
);
debug!(
"received DkgPrivateShares from signer {} {}/{}",
dkg_private_shares.signer_id,
Expand Down
Loading