Only store verified encrypted private shares within Signer#86
Closed
Only store verified encrypted private shares within Signer#86
Conversation
jferrant
commented
Jun 7, 2024
| self.decrypted_shares.insert(*src_id, decrypted_shares); | ||
| self.decryption_keys | ||
| .insert(*src_id, (dkg_private_shares.signer_id, shared_key)); | ||
| verified_shares.push((*src_id, encrypted_shares)); |
Collaborator
Author
There was a problem hiding this comment.
This could result in empty encrypted shares hashmap per src_id. I assumed this was okay. but just confirming?
xoloki
requested changes
Sep 25, 2024
Owner
xoloki
left a comment
xoloki
left a comment
There was a problem hiding this comment.
Can you add a test to show that nothing crashes if there are no verified shares?
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
jferrant
force-pushed
the
bugfix/fix-invalid-private-share-storage
branch
from
a184a95 to
d99a7b8
Compare
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Collaborator
Author
|
Not really beneficial anymore. We store all the private shares and report the bad ones during DKG/SIgn. These bad shares are never used except for error reporting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to add a test I think.