Require g:rspec_runner explicitly

[gylaz]

If g:rspec_runner is not provided
the g:rspec_command will be piped to GUI vim as-is.

This allows users to use vim-dispatch with GUI vim.

[gylaz]

ping @christoomey @jferris

[gylaz]

The only problem I see here is that out-of-the box, this doesn't work for MacVim because the default spec command won't work without !. Could we maybe provide a default runner only when a custom command and a custom runner aren't provided? Any other ideas?

[christoomey]

Would it be possible for this to point to something more in the users control? Perhaps a script in ~/bin? They might need to hard code the path, and I believe the script execution in the plugin would need to be updated, but I think that could be a better approach. Otherwise they would need to either gitignore their script, or rebase a branch, or otherwise manage it as an addition to the repo.

[gylaz]

Interesting idea. It think this would be a good approach, with allowing people to override the default bin/ path. However, there's no evidence that people are even using this feature. Thus, it would be low priority to focus on something, that's not a reported problem.

[christoomey]

Overall I think the explicitness requirement is fine, and the readme updates seems good to cover the change. I did have one concern about recommending they add their custom script to the plugin bin/ directory which I commented on inline.

[gylaz]

Thanks, @christoomey.