Allow for override of gui external runner#64
Closed
Attamusc wants to merge 1 commit intothoughtbot:masterfrom
Closed
Allow for override of gui external runner#64Attamusc wants to merge 1 commit intothoughtbot:masterfrom
Attamusc wants to merge 1 commit intothoughtbot:masterfrom
Conversation
Contributor
|
What is your use case that you don't want to use an |
Author
|
I currently have a set up like in this article, where |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using vim-rspec for a while and it's awesome, but the recent update to allow for both
g:rspec_runnerandg:rspec_commandbreaks my current workflow that I think others might also have: MacVim and tmux. Currently, all commands when run in gui vim are executed using the configured runner. This means that, even with a custom command, gui vim will not be able to execute anything inside of vim to externally run the command.I added a global variable that allows the user to explicitly state if they do or do not want to use a runner script. This variable is set to true by default so that the current behavior without setting either
rspec_commandorrspec_runnerremains the same.While I don't think this is necessarily the best way to do this, it is "a way" and it requires minimal change. If there is a better way to do this, please let me know; if not, I'd be happy to also update the README with references to this variable.