Skip to content

[ENH] Add regression test ensuring filter_tags in all_objects does not return empty results#512

Open
shourya1419-netizen wants to merge 4 commits intosktime:mainfrom
shourya1419-netizen:test-filter-tags-regression
Open

[ENH] Add regression test ensuring filter_tags in all_objects does not return empty results#512
shourya1419-netizen wants to merge 4 commits intosktime:mainfrom
shourya1419-netizen:test-filter-tags-regression

Conversation

@shourya1419-netizen
Copy link

Summary

Adds a regression test to ensure that filter_tags in all_objects does not return empty results when matching objects exist.

What this PR does

Adds a test case verifying that objects with matching tags are correctly returned.

Prevents regression of the bug described in #162 where all_objects(filter_tags=...) returned an empty result.

Related Issue

Closes #162

@fkiraly fkiraly changed the title #162 Add regression test ensuring filter_tags in all_objects does not return empty results [ENH] Add regression test ensuring filter_tags in all_objects does not return empty results Mar 5, 2026
@fkiraly fkiraly added the enhancement Adding new functionality label Mar 5, 2026
Copy link
Contributor

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this almost identical to changes in #476?

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.45%. Comparing base (306958d) to head (7814248).
⚠️ Report is 186 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   85.07%   83.45%   -1.62%     
==========================================
  Files          45       52       +7     
  Lines        3015     3905     +890     
==========================================
+ Hits         2565     3259     +694     
- Misses        450      646     +196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shourya1419-netizen
Copy link
Author

Why is this almost identical to changes in #476?

Thanks for pointing this out.

While the change may look similar to #476, the purpose of this PR is slightly different.
PR #476 focuses on testing the behavior of filter_tags in a different context, whereas this PR adds a regression test to ensure that using filter_tags with all_objects does not return empty results.

So this test specifically guards against a regression in the all_objects filtering behavior.

Copy link
Contributor

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Please do that without writing code at runtime.

@shourya1419-netizen
Copy link
Author

Thanks for the feedback. I’ve updated the test to remove the runtime code generation and now rely on existing objects when checking "filter_tags". The changes have been pushed to the branch. Please let me know if any further adjustments are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adding new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] ensure test coverage of #161 failure case

2 participants