[ENH] Add regression test ensuring filter_tags in all_objects does not return empty results#512
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 85.07% 83.45% -1.62%
==========================================
Files 45 52 +7
Lines 3015 3905 +890
==========================================
+ Hits 2565 3259 +694
- Misses 450 646 +196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for pointing this out. While the change may look similar to #476, the purpose of this PR is slightly different. So this test specifically guards against a regression in the |
fkiraly
left a comment
There was a problem hiding this comment.
I see. Please do that without writing code at runtime.
|
Thanks for the feedback. I’ve updated the test to remove the runtime code generation and now rely on existing objects when checking "filter_tags". The changes have been pushed to the branch. Please let me know if any further adjustments are needed. |
Summary
Adds a regression test to ensure that filter_tags in all_objects does not return empty results when matching objects exist.
What this PR does
Adds a test case verifying that objects with matching tags are correctly returned.
Prevents regression of the bug described in #162 where all_objects(filter_tags=...) returned an empty result.
Related Issue
Closes #162