[ENH] tests(lookup): isolate lookup tests to dedicated mock package#476
Open
arnavk23 wants to merge 34 commits intosktime:mainfrom
Open
[ENH] tests(lookup): isolate lookup tests to dedicated mock package#476arnavk23 wants to merge 34 commits intosktime:mainfrom
arnavk23 wants to merge 34 commits intosktime:mainfrom
Conversation
…isolate tests to skbase.tests.mock_package (fix sktime#114)
…e to improve mock coverage (edge cases)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
arnavk23
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| __author__: List[str] = ["fkiraly", "RNKuhns"] | ||
|
|
||
|
|
||
| class Parent(BaseObject): |
Check warning
Code scanning / CodeQL
`__eq__` not overridden when adding attributes Warning test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
- Coverage 85.07% 83.83% -1.24%
==========================================
Files 45 52 +7
Lines 3015 3904 +889
==========================================
+ Hits 2565 3273 +708
- Misses 450 631 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arnavk23
force-pushed
the
fix/issue-114-restrict-lookup-tests
branch
2 times, most recently
from
0c30a63 to
6e00981
Compare
…n mock_package modules Classes defined in test_fixtures.py should only appear in that module's metadata, not in __init__.py or test_mock_package.py where they're imported. Removed Parent, Child, ClassWithABTrue from __all__ lists to match the test's expectation that get_package_metadata only reports classes actually defined in each module (cls.__module__ == module.__name__).
…ckage Classes are imported for re-export to maintain the module's public API but are intentionally not listed in __all__ to ensure get_package_metadata only reports classes defined in each module.
for more information, see https://pre-commit.ci
fkiraly
requested changes
Feb 13, 2026
Contributor
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Great!
There is though an entire config file which checks expectations against actuals after retrieval.
I would expect that still to happen for the mock package, but it does not - are you sure you have moved all tests over? I would at least expect the "full package expected lookup results" to be removed.
…strict the lookup tests to only those that are relevant to the issue at hand.
for more information, see https://pre-commit.ci
fkiraly
reviewed
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #114.
What does this implement/fix? Explain your changes.
This PR isolates
lookuptests from the main package by introducing a dedicated test-only package,skbase.tests.mock_package.The lookup tests scan this small controlled package instead of scanning
skbasedirectly. This decouples lookup tests from unrelated production-package refactors and prevents brittle failures when internals outside lookup change.Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
mock_packageexpectations accurately model intendedlookupbehavior.Any other comments?
The intent is to make lookup tests deterministic and focused on lookup behavior, not on unrelated evolution of the production package structure.
PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions