refactor(form): use container queries for automatic layout#1757
Draft
refactor(form): use container queries for automatic layout#1757
Conversation
1 task
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the si-form-container component to utilize CSS container queries for responsive behavior, replacing the SiResponsiveContainerDirective. This includes updates to the component's template, styles, and TypeScript file, and deprecates the contentContainerBreakpoints input. The review suggests improving maintainability and preventing naming conflicts by consistently prefixing the new CSS container name with si-form-container in both the component's SCSS and the shared SCSS file.
projects/element-ng/form/si-form-container/si-form-container.component.scss
Outdated
Show resolved
Hide resolved
dr-itz
force-pushed
the
refactor/form-better-css-2
branch
from
5577822 to
87089cd
Compare
DEPRECATED: In `si-form-container`, the input `contentContainerBreakpoints` no longer has any effect.
dr-itz
force-pushed
the
refactor/form-better-css-2
branch
from
87089cd to
59671af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPRECATED: In
si-form-container, the inputcontentContainerBreakpointsno longer has any effect.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: