refactor(form): use col-form-label in inline mode#609
refactor(form): use col-form-label in inline mode#609spike-rabbit wants to merge 1 commit intomainfrom
col-form-label in inline mode#609Conversation
312daae to
b3c732b
Compare
f6156c3 to
e06b51d
Compare
Previously we overrode the `.form-label` when the form-item switched to the inline mode. With this change, we just use the bootstrap standard class. See https://getbootstrap.com/docs/5.3/forms/layout/#horizontal-form.
e06b51d to
da1f84b
Compare
|
@dr-itz what do you think here? The benefits in my opinion are:
Downsides:
|
|
The CSS Angular generates for all the Much smaller CSS and a pure CSS solution. (At some point we might consider container queries instead and drop the resize observer from the forms 🤷 ) |
so...that breaks because when using si-form-item w/o a si-form-container... |
|
Using container queries: #1757 |
Previously we overrode the
.form-labelwhenthe form-item was switched to the inline mode.
With this change, we just use the bootstrap standard class.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: