feat: support PSK after receiving HelloRetryRequest (HRR)#305
Draft
feat: support PSK after receiving HelloRetryRequest (HRR)#305
Conversation
Add UpdateOnHRR to allow PSK to recalculate its state using previously transcribed Client Hello's hash and client handshake state. Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
Signed-off-by: Gaukas Wang <i@gaukas.wang>
Contributor
Author
|
To those who have contributed to uTLS recently regarding PSK-related topics, I would appreciate it if you'd like to share your thoughts on my change included in this PR. cc: @adotkhan, @sleeyax, @VeNoMouS, @3andne This is just an unordered, incomplete list of uTLS contributors on PSK. If you are not mentioned but would share your thoughts, please feel free to do so! |
Contributor
|
Rgr Rgr, will try find some time this weekend to investigate and test |
|
Just fixed and opened a PR for this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no proper support for PSK if server sends a Hello Retry Request asking uTLS to switch to a different Key Share that is supported but not sent by default:
utls/handshake_client_tls13.go
Lines 413 to 416 in 841ef93
This pull request adds support to handle PSK after seeing HRR.