feat: support PSK binder reprocessing on HelloRetryRequest#389
Open
thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
Open
feat: support PSK binder reprocessing on HelloRetryRequest#389thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
Conversation
Previously, uTLS would return a hard error when a HelloRetryRequest was received and PSK identities were present in the ClientHello: "uTLS does not support reprocessing of PSK key triggered by HelloRetryRequest" This commit adds full HRR PSK support by: - Adding UpdateOnHRR method to the PreSharedKeyExtension interface - Implementing UpdateOnHRR on UtlsPreSharedKeyExtension to refresh the session, cipher suite, obfuscated ticket age, and store the previous ClientHello hash and ServerHello for transcript reconstruction - Extending PatchBuiltHello to reconstruct the HRR transcript (message_hash of first CH + ServerHello + second CH) per RFC 8446 Section 4.4.1 before recomputing PSK binders - Updating processHelloRetryRequest to call UpdateOnHRR + PatchBuiltHello with graceful fallback (clearing PSK on failure rather than aborting) This enables TLS 1.3 session resumption to work correctly even when the server sends a HelloRetryRequest, which is common with post-quantum key exchanges and certain server configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, uTLS would return a hard error when a HelloRetryRequest was received and PSK identities were present in the ClientHello: "uTLS does not support reprocessing of PSK key triggered by HelloRetryRequest" (see #305)
This commit adds full HRR PSK support by:
This enables TLS 1.3 session resumption to work correctly even when the server sends a HelloRetryRequest, which is common with post-quantum key exchanges and certain server configurations.