Add backport tips and PR title convention to CLAUDE.md#7493
Add backport tips and PR title convention to CLAUDE.md#7493
Conversation
CLAUDE.md
Outdated
| ## Contributing | ||
|
|
||
| When preparing to commit and create a PR you **must** follow our [PR checklist](https://pulpproject.org/pulpcore/docs/dev/guides/pull-request-walkthrough/) | ||
| When preparing to commit and create a PR you **must** follow our [PR checklist](https://pulpproject.org/pulpcore/docs/dev/guides/pull-request-walkthrough/) Important to note is the AI attribution requirement in our commit messages. Also, note that our changelog entries use single ticks for code related text. |
There was a problem hiding this comment.
I was about to create a PR to add the single ticks observation to CLAUDE.md 😅
But I guess it's useful to state that the changes fragments are markdown documents (which implicitly means single ticks, as opposed to rst double ticks).
There was a problem hiding this comment.
'changelog entries are rendered into markdown' or 'changelog entries are markdown'?
| When patchback fails to cherry-pick a PR into an older branch, you need to manually apply the equivalent change. Key things to know: | ||
|
|
||
| - Older branches (e.g. 3.49, 3.63) may use `requirements.txt` for dependencies, while newer branches use `pyproject.toml`. Always check which file the target branch uses before applying changes. | ||
| - When creating a PR include `[<version>]` in the PR title (e.g. `[3.49] Update pyopenssl requirement from <26.0 to <27.0`). |
There was a problem hiding this comment.
I don't think any of our documents mention that we prefer to use git cherry-pick -x when doing backports
There was a problem hiding this comment.
Usually it'll choose -x since it reads the patchback bot's comments (at least it does when I prompt it) and sees the command the bot failed to finish. Let me test another backport without the explicit mention.
There was a problem hiding this comment.
Ok, with the prompt "Let's backport the new datarepair management command to 3.85 and 3.105" it produced this: #7494 and didn't use -x option. Let me add it to the tips.
Co-authored-by: Claude <noreply@anthropic.com> Made-with: Cursor
gerrod3
force-pushed
the
update-claude-md
branch
from
b73f55e to
83cf1b5
Compare
3 participants
Summary
requirements.txtvspyproject.toml).[<version>]PR title convention for backport PRs.Made with Cursor