fix: resolve shell syntax in run() calls across all tools#116
Closed
TerminalGravity wants to merge 2 commits intomainfrom
Closed
fix: resolve shell syntax in run() calls across all tools#116TerminalGravity wants to merge 2 commits intomainfrom
TerminalGravity wants to merge 2 commits intomainfrom
Conversation
Covers LanceDB native binary failures, CLAUDE_PROJECT_DIR config, vector search not returning results, MCP handshake debugging, and performance tips. Links from README nav bar.
Add shell() helper to git.ts for commands that genuinely need shell features (pipes, redirects, ||). Convert simple git commands to use run() with array args. Replace shell-based file operations (cat, wc) with native Node.js fs calls where possible. Files fixed: verify-completion, token-audit, audit-workspace, enrich-agent-task, clarify-intent, session-handoff, scope-work, sequence-tasks, session-health, sharpen-followup, checkpoint, what-changed (13 files total). Closes #110
Collaborator
Author
|
Reviewed — this is the cleanest version of the #110 fix. The three-tier approach (array args for simple git, Two things to watch:
Ready to merge. |
This was referenced Mar 5, 2026
Collaborator
Author
Collaborator
Author
|
Closing — superseded by #120 which covers more files with the same approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110
What
Adds a
shell()helper tosrc/lib/git.tsfor commands that genuinely need shell features (pipes, redirects,||), and fixes all 13 affected tool files to use the correct execution method:run()with array args (no shell, safe from injection)shell()(explicit shell use)fscallsFiles changed (13)
git.ts,verify-completion.ts,token-audit.ts,audit-workspace.ts,enrich-agent-task.ts,clarify-intent.ts,session-handoff.ts,scope-work.ts,sequence-tasks.ts,session-health.ts,sharpen-followup.ts,checkpoint.ts,what-changed.tsTesting
tsc --noEmitpasses clean