fix(tools): replace shell syntax in run() calls with shell()/exec()/array args#113
Closed
TerminalGravity wants to merge 1 commit intomainfrom
Closed
fix(tools): replace shell syntax in run() calls with shell()/exec()/array args#113TerminalGravity wants to merge 1 commit intomainfrom
TerminalGravity wants to merge 1 commit intomainfrom
Conversation
…rray args (closes #110)
TerminalGravity
commented
Mar 5, 2026
Collaborator
Author
TerminalGravity
left a comment
There was a problem hiding this comment.
Solid approach — the three-tier strategy (array args for simple git, shell() for pipes/redirects, exec() for non-git binaries) is clean. The security comment on shell() is appreciated.
A couple notes:
- The
shellEscape()mention in the JSDoc — is that implemented somewhere? Didn't see it in the diff. Might want to either add it or remove the reference to avoid confusion. - Timeout default of 10s in
shell()seems tight forpnpm tsc --noEmiton larger projects. Worth bumping or making configurable per-call.
This supersedes #109, #111, #112, #101, #100 — those should be closed once this lands. 🚀
This was referenced Mar 5, 2026
Collaborator
Author
|
Closing — superseded by #116 which covers all files with the cleaner three-tier approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110. Converts all tool files that were passing shell syntax (pipes, redirects, ||, &&) to run() (which uses execFileSync without a shell) to use the appropriate helper:
Files fixed: verify-completion, token-audit, clarify-intent, session-handoff, audit-workspace, sharpen-followup, what-changed, scope-work, session-health, enrich-agent-task, checkpoint, sequence-tasks