Updates for PHP 8.4 compatibility#285
Open
ReadyCloudSuite wants to merge 3 commits intophacility:masterfrom
Open
Updates for PHP 8.4 compatibility#285ReadyCloudSuite wants to merge 3 commits intophacility:masterfrom
ReadyCloudSuite wants to merge 3 commits intophacility:masterfrom
Conversation
…ied as nullable is deprecated, the explicit nullable type must be used instead"
…d, the explicit nullable type must be used instead" errors.
…|int is deprecated" error.
|
Thanks, I applied this patch and arcanist is working again. I also had to turn off deprecation warnings to be able to parse the JSON output. diff --git a/bin/arc b/bin/arc
index 51528ca0..696f8191 100755
--- a/bin/arc
+++ b/bin/arc
@@ -1,5 +1,6 @@
#!/usr/bin/env php
<?php
+error_reporting(E_ALL ^ E_DEPRECATED);
if (function_exists('pcntl_async_signals')) {
pcntl_async_signals(true); |
|
Please can somebody merge this to master. |
2 similar comments
|
Please can somebody merge this to master. |
|
Please can somebody merge this to master. |
|
@semsudin @dushaoshuai @ez4bk |
|
Lol, I downgraded php as a short term mitigation. 8.4 is officially broken in this repo. 8.3 is still supported... for now. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FutureProxy::__construct(): Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead.Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead.Passing null to parameter #1 ($status) of type string|int is deprecated.