Add explicit null typing on generate certificat#287
Closed
Ludovic-Potvin wants to merge 1 commit intophacility:masterfrom
Closed
Add explicit null typing on generate certificat#287Ludovic-Potvin wants to merge 1 commit intophacility:masterfrom
Ludovic-Potvin wants to merge 1 commit intophacility:masterfrom
Conversation
Ludovic-Potvin
changed the title
Author
|
Just saw this PR: #285 Im gonna close mine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New php versions require explicit typing for null type on $proxied.
This cause issue in arc generate-certificate and prevent the certificat generation.
This PR fix it by adding the null typing.
Test plan
1 - type arc generate-certificate
2 - Pull this branch
3 - type arc generate-certificate