Strip trailing slash from endpoint to prevent malformed URIs#288
Merged
aviadhahami merged 3 commits intomasterfrom Mar 21, 2026
Merged
Strip trailing slash from endpoint to prevent malformed URIs#288aviadhahami merged 3 commits intomasterfrom
aviadhahami merged 3 commits intomasterfrom
Conversation
…s in URIs Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com> Agent-Logs-Url: https://github.com/nodevault/node-vault/sessions/18acbdc1-2e5a-4a10-8209-9c26eefda931
Copilot
AI
changed the title
[WIP] Fix issue with Vault API response handling
Strip trailing slash from endpoint URL
Mar 21, 2026
…ash endpoint Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com> Agent-Logs-Url: https://github.com/nodevault/node-vault/sessions/909d7cff-651f-47c2-b036-1f413bb6e575
Copilot
AI
changed the title
Strip trailing slash from endpoint URL
Strip trailing slash from endpoint to prevent malformed URIs
Mar 21, 2026
aviadhahami
approved these changes
Mar 21, 2026
Copilot stopped work on behalf of
aviadhahami due to an error
March 21, 2026 12:08
Copilot AI
added a commit
that referenced
this pull request
Mar 21, 2026
Strip trailing slash from endpoint to prevent malformed URIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
endpoint(orVAULT_ADDR) includes a trailing slash (e.g.http://127.0.0.1:8200/), URI construction produces double slashes likehttp://127.0.0.1:8200//v1/secret/hello.Fix: Strip trailing slash from
client.endpointat init time, before it's used in URI template on the request path.Tests: Added three tests covering:
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.