Document trailing slash handling, close #175#291
Merged
aviadhahami merged 2 commits intomasterfrom Mar 21, 2026
Merged
Conversation
Closes #175 Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com> Agent-Logs-Url: https://github.com/nodevault/node-vault/sessions/c1ac458b-4e57-4624-90ae-2d76913d4139
Copilot
AI
changed the title
[WIP] Close tickets related to pull request 288
Document trailing slash handling, close #175
Mar 21, 2026
aviadhahami
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #288 merged the fix for trailing slash endpoint handling but didn't reference issue #175, leaving it open.
endpoint/VAULT_ADDRare automatically stripped to prevent malformed URIs (e.g.http://127.0.0.1:8200//v1/secret/hello)💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.