Skip to content

nirfsg: Enable gRPC support without tests#2171

Open
rahur-NI wants to merge 4 commits intoni:masterfrom
rahur-NI:nirfsgGrpcEnable
Open

nirfsg: Enable gRPC support without tests#2171
rahur-NI wants to merge 4 commits intoni:masterfrom
rahur-NI:nirfsgGrpcEnable

Conversation

@rahur-NI
Copy link
Contributor

@rahur-NI rahur-NI commented Mar 18, 2026

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Enabled gRPC support for nirfsg by including nirfsg.proto file. This file is picked from grpc-device repository.
  • Updated functions.py metadata to add grpc_enum mappings for set attribute APIs.
  • Updated gRPC stub interpreter template for nirfsg for get_deembedding_sparameters to resolve flake issue.

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • codegen changes in generated and doc folder are as needed.
  • System tests for grpc are intentionally not included as part of this change as complex datatype support (required for certain test scenarios) will be addressed in a follow-up PR.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 7.16846% with 259 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.77%. Comparing base (c328bc3) to head (0d0e209).

Files with missing lines Patch % Lines
generated/nirfsg/nirfsg/_grpc_stub_interpreter.py 0.00% 253 Missing ⚠️
generated/nirfsg/nirfsg/grpc_session_options.py 75.00% 4 Missing ⚠️
generated/nirfsg/nirfsg/session.py 77.77% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (7.16%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2171      +/-   ##
==========================================
- Coverage   89.98%   88.77%   -1.22%     
==========================================
  Files          71       73       +2     
  Lines       18711    18986     +275     
==========================================
+ Hits        16837    16854      +17     
- Misses       1874     2132     +258     
Flag Coverage Δ
codegenunittests 84.90% <ø> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.68% <ø> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 73.02% <7.16%> (-8.29%) ⬇️
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nirfsg/nirfsg/_library_interpreter.py 74.14% <100.00%> (+0.03%) ⬆️
generated/nirfsg/nirfsg/session.py 89.88% <77.77%> (-0.18%) ⬇️
generated/nirfsg/nirfsg/grpc_session_options.py 75.00% <75.00%> (ø)
generated/nirfsg/nirfsg/_grpc_stub_interpreter.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c328bc3...0d0e209. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahur-NI rahur-NI changed the title nirfsg: Enable gRPC support nirfsg: Enable gRPC support without tests Mar 20, 2026
@rahur-NI rahur-NI marked this pull request as ready for review March 20, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants