Add CancellationToken and async hydration to GitStatusCache#1914
Conversation
tyrielv
commented
Mar 17, 2026
- Add CancellationToken parameter to CreateSummary (default: none)
- Check cancellation between each phase of summary computation
- Separate OperationCanceledException catch returns invalid summary
- GitStatusCache creates CancellationTokenSource, cancels on Shutdown
- Run UpdateHydrationSummary in parallel with TryRebuildStatusCache via Task.Run — independent operations should not delay each other
- Add CancellationToken parameter to CreateSummary (default: none) - Check cancellation between each phase of summary computation - Separate OperationCanceledException catch returns invalid summary - GitStatusCache creates CancellationTokenSource, cancels on Shutdown - Run UpdateHydrationSummary in parallel with TryRebuildStatusCache via Task.Run — independent operations should not delay each other Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ff67270 to
e88b403
Compare
|
(Corrected re-post — the original review had rendering issues with backtick escaping) Clean cancellation support and a good parallelization win. Two suggestions:
The cancellation-vs-error distinction is well handled — returning an invalid summary with no Minor: a couple of extra blank lines around |
Resolve conflicts in EnlistmentHydrationSummary.cs and GitStatusCache.cs by combining ITracer + Stopwatch timing from this branch with CancellationToken support from PR microsoft#1914. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>