Improve exception logging and telemetry for hydration status#1912
Improve exception logging and telemetry for hydration status#1912tyrielv merged 2 commits intomicrosoft:masterfrom
Conversation
tyrielv
commented
Mar 17, 2026
- Thread ITracer through EnlistmentHydrationSummary.CreateSummary()
- Add Stopwatch timing per phase with HydrationSummaryDuration telemetry
- Log RelatedWarning on early exit with specific invalid count values
- Log RelatedError in catch block with elapsed duration
- Add exception handling to LoadModifiedPaths file fallback with ITracer
- Add null check in ReadModifiedPathDatabaseLines to prevent NRE
- Thread ITracer through EnlistmentHydrationSummary.CreateSummary() - Add Stopwatch timing per phase with HydrationSummaryDuration telemetry - Log RelatedWarning on early exit with specific invalid count values - Log RelatedError in catch block with elapsed duration - Add exception handling to LoadModifiedPaths file fallback with ITracer - Add null check in ReadModifiedPathDatabaseLines to prevent NRE Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8a751f1 to
d695489
Compare
|
(Corrected re-post — the original review had rendering issues with backtick escaping) Good changes overall — solid observability improvement. A few notes:
The per-phase Looks good to merge. |
Resolve conflicts in EnlistmentHydrationSummary.cs and GitStatusCache.cs by combining ITracer + Stopwatch timing from this branch with CancellationToken support from PR microsoft#1914. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>