Skip to content

Add Python to Language Matrix#72

Open
JacksonWeber wants to merge 3 commits intomasterfrom
jacksonweber/add-python-codeql
Open

Add Python to Language Matrix#72
JacksonWeber wants to merge 3 commits intomasterfrom
jacksonweber/add-python-codeql

Conversation

@JacksonWeber
Copy link
Copy Markdown
Contributor

@JacksonWeber JacksonWeber commented Apr 15, 2025

Add Python to language matrix.

@TimothyMothra
Copy link
Copy Markdown

I can't tell if this change will conflict with this line in the other file:

strategy:
fail-fast: false
matrix:
language: [ 'cpp' ]

I'm not an expert on the codeQL configuration, but if this was my repo I would merge these two files to keep it simple.

I'm fine with merging this change and waiting a few days to see if the SFI task resolves.
If the task doesn't resolve, I want to set the expectation that we may need further changes.

@JacksonWeber
Copy link
Copy Markdown
Contributor Author

I can't tell if this change will conflict with this line in the other file:

strategy:
fail-fast: false
matrix:
language: [ 'cpp' ]

I'm not an expert on the codeQL configuration, but if this was my repo I would merge these two files to keep it simple.

I'm fine with merging this change and waiting a few days to see if the SFI task resolves. If the task doesn't resolve, I want to set the expectation that we may need further changes.

It almost certainly will, sorry I added this to the wrong configuration file, I'll update that now.

@TimothyMothra
Copy link
Copy Markdown

It almost certainly will, sorry I added this to the wrong configuration file, I'll update that now.

no worries, we're learning together. Thanks for making the change

@JacksonWeber
Copy link
Copy Markdown
Contributor Author

It almost certainly will, sorry I added this to the wrong configuration file, I'll update that now.

no worries, we're learning together. Thanks for making the change

Updated and ready for re-review

@TimothyMothra
Copy link
Copy Markdown

haha, the CodeQL workflow is failing:

Exit code was 32 and last log line was: CodeQL detected code written in C/C++ and JavaScript/TypeScript, but not any written in Python. Confirm that there is some source code for Python in the project. For more information, review our troubleshooting guide at

Is it possible that you're excluding the directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants