Open
Conversation
ADL doesn't apply to invocations
Also ordered before use
The true issue is blanket `using` directives. It doesn't get much more
inviting to ambiguities than what is found in src/Helpers.hpp:
using namespace std;
using namespace boost;
using namespace boost::assign;
using namespace boost::posix_time;
using namespace boost::gregorian;
This is just the cheap compilation fix
see comment at 02ed807
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of fixes were require to make the code compile¹
For reference: http://stackoverflow.com/a/34330252/85371
¹ currently fails to link for me, probably due to changes in the netcdf library; I had to install libnetcdf-cxx-legacy-dev to get the netcdfcpp.h header