template reordering and ambiguity clarification#1
template reordering and ambiguity clarification#1tpajenkamp wants to merge 1 commit intomeierue:masterfrom
Conversation
* Helpers.hpp needed some templates to be reordered. * Function range() from Helpers.hpp was called in an ambiguous way on several occurances. Project did not compile on my machine (Ubuntu 14.04.3 LTS, g++ 4.8.4, Boost 1.54). The changes above where necessary to make it work.
|
Have you tried this? https://github.com/xavigonzalvo/rnnlib |
|
It is solely based on the code posted on sourceforge (http://sourceforge.net/projects/rnnl/), isn't it? I want to test the regression feature which does not work with that version, as far as I can tell. |
|
Ah ok! Yes it is.
|
|
Ah. We fixed mostly the same issues in mostly the same way. #2 You missed the unqualified ::equal that also prevented successful compilation on my Ubuntu 15.10 Also, I think the fix to Finally, my pull request has the changes nicely split out into separate commits. (not posting this as a critique; posting it to save time for others reviewing the differences) Cheers! |
|
Thanks for the comment. The fixes worked on my machine and I assumed the function signature was correct, but I guess you are right. |
on several occurances.
Project did not compile on my machine (Ubuntu 14.04.3 LTS, g++ 4.8.4, Boost 1.54). The changes above where necessary to make it work.