-
Notifications
You must be signed in to change notification settings - Fork 4
Linting workflow and pre-commit #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tsmathis
merged 47 commits into
materialsproject:master
from
HugoOnghai:linting-workflow
Aug 4, 2025
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
a97b97f
updating dependencies
HugoOnghai afa51f7
Trying to get test_doi_builder to work
HugoOnghai 79c48f2
Revert "Trying to get test_doi_builder to work"
HugoOnghai 7bb812e
preliminary version of ELinkGetResponseModel made, using ELinkAPI Re…
HugoOnghai 2005e5d
queried all desired data entries (stored as batched json files) on EL…
HugoOnghai 8700859
almost done with pipeline, need to incorporate pymongo steps + new do…
HugoOnghai 11c48e5
template for core
tsmathis ba3c372
push latest doi_builder and other thigns
HugoOnghai a747326
find_out_of_date func
tsmathis 1020d1f
remaining core functions
HugoOnghai b34ae35
testing core functionalities on review environment and local mongo da…
HugoOnghai 52382ff
Merged upstream (#1)
HugoOnghai d0e05ec
Added linting workflow, hopefully it works
HugoOnghai 9391660
Testing linting workflow again
HugoOnghai b991f09
New Branch for Linting Workflow
HugoOnghai 8d7d55b
Testing Linting workflow
HugoOnghai 61d74c1
Allowing Lint.YML to run on push to linting_workflow
HugoOnghai d9ab19c
Testing pre-commit and updated lint.yml to disregard legacy files
HugoOnghai 5b96fa5
disable fail-fast to see if other python versions will fail
HugoOnghai bdac205
Using uv to install ruff dependency, using uv-cache and removing pip …
HugoOnghai 2e7b9ab
added new action to install virtual environment before attempting to …
HugoOnghai 64a5c07
Fixed missing run for uv venv
HugoOnghai c4d9a8f
attempting ruff check again now that is seems to work...
HugoOnghai 69556e5
Trying uvx
HugoOnghai 8cab90f
Removed assume python 3.9 from ruff config in pyproject.toml
HugoOnghai edd887e
New Branch for Linting Workflow
HugoOnghai 4657ea3
Testing Linting workflow
HugoOnghai 5c9197e
(after rebase) Allowing Lint.YML to run on push to linting_workflow
HugoOnghai 122e4cb
Testing pre-commit and updated lint.yml to disregard legacy files
HugoOnghai f9e4753
disable fail-fast to see if other python versions will fail
HugoOnghai 18cf3d2
Using uv to install ruff dependency, using uv-cache and removing pip …
HugoOnghai 059c72d
added new action to install virtual environment before attempting to …
HugoOnghai 1350d61
Fixed missing run for uv venv
HugoOnghai 16e6a33
attempting ruff check again now that is seems to work...
HugoOnghai 7ee8fb5
(after rebase) Trying uvx
HugoOnghai 4a83b7a
Removed assume python 3.9 from ruff config in pyproject.toml
HugoOnghai 5f2f948
fixing typos after rebase
HugoOnghai c8c53cb
Installing Ruff before calling check; added precommit to uvlock
HugoOnghai 5f2262a
Added verbose keyword to make clear that files are being checked
HugoOnghai 0942819
Trying to remove extraneous files from PR
HugoOnghai 930cf9f
Attempting to revert src/ tests/ and .gitignore to master current ver
HugoOnghai a1423ed
Readded release and testing default workflows to match master
HugoOnghai c53df93
Readd changelog to match master
HugoOnghai 2a94abd
restored old version of gitignore
HugoOnghai 9c022d6
Fixing PR comments
HugoOnghai bef3f59
fix
HugoOnghai a797639
added mypy and ruff to a dependency group called lint
HugoOnghai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| repos: | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| # Ruff version. | ||
| rev: v0.12.4 | ||
| hooks: | ||
| # Run the linter. | ||
| - id: ruff-check | ||
| types_or: [ python, pyi ] | ||
| args: [ --fix ] | ||
| # Run the formatter. | ||
| - id: ruff-format | ||
| types_or: [python, pyi ] | ||
| exclude: 'legacy' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.