Linting workflow and pre-commit#26
Merged
tsmathis merged 47 commits intomaterialsproject:masterfrom Aug 4, 2025
Merged
Conversation
after upgrading... pip freeze > requirements.txt the old requirements are saved in oldrequirements.txt for reference
- deserialization works - re-serialization does not, there are additional dictionary keys that exist that don't match the provided config_file. will need to discuss the goal of this doi_builder a bit more to understand it
This reverts commit afa51f7.
…ink found bug with rows greater than 100 on ElinkAPI query_records (144845 dois under 10.17188, 12 are not titled Materials Data On... (edge cases), 144833 Materials have DOIs)
* move old code to 'legacy' * setup project using uv * add license * testing skeleton * gh actions skeleton * remove old reqs file to prevent dependabot alerts --------- Co-authored-by: Tyler Mathis <35553152+tsmathis@users.noreply.github.com>
…install dependency
…install dependency
HugoOnghai
force-pushed
the
linting-workflow
branch
from
8cab90f to
5f2262a
Compare
Collaborator
|
First thing, can you remove all of the files/directories that are not related to linting? Looks like |
Collaborator
Author
fixed now! i'll make sure the rest are cleaned up too |
tsmathis
reviewed
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes