Skip to content

fix: update to new lvt testing API #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adnaan wants to merge 1 commit into from
Closed

fix: update to new lvt testing API #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions avatar-upload/avatar-upload_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,10 @@ func TestAvatarUploadE2E(t *testing.T) {
}()

// Start Docker Chrome container
chromeCmd := e2etest.StartDockerChrome(t, debugPort)
defer e2etest.StopDockerChrome(t, chromeCmd, debugPort)
if err := e2etest.StartDockerChrome(t, debugPort); err != nil {
t.Fatalf("Failed to start Chrome: %v", err)
}
defer e2etest.StopDockerChrome(t, debugPort)

// Connect to Docker Chrome via remote debugging
chromeURL := fmt.Sprintf("http://localhost:%d", debugPort)
Expand Down
6 changes: 4 additions & 2 deletions counter/counter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,10 @@ func TestCounterE2E(t *testing.T) {
}()

// Start Docker Chrome container
chromeCmd := e2etest.StartDockerChrome(t, debugPort)
defer e2etest.StopDockerChrome(t, chromeCmd, debugPort)
if err := e2etest.StartDockerChrome(t, debugPort); err != nil {
t.Fatalf("Failed to start Chrome: %v", err)
}
defer e2etest.StopDockerChrome(t, debugPort)

// Connect to Docker Chrome via remote debugging
chromeURL := fmt.Sprintf("http://localhost:%d", debugPort)
Expand Down
6 changes: 4 additions & 2 deletions todos/todos_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,10 @@ func TestTodosE2E(t *testing.T) {
t.Logf("✅ Test server ready at %s", serverURL)

// Start Docker Chrome container
chromeCmd := e2etest.StartDockerChrome(t, debugPort)
defer e2etest.StopDockerChrome(t, chromeCmd, debugPort)
if err := e2etest.StartDockerChrome(t, debugPort); err != nil {
t.Fatalf("Failed to start Chrome: %v", err)
}
defer e2etest.StopDockerChrome(t, debugPort)

// Connect to Docker Chrome via remote debugging
chromeURL := fmt.Sprintf("http://localhost:%d", debugPort)
Expand Down
Loading