Conversation
Update all examples to use the new lvt testing API: - StartDockerChrome now returns error instead of *exec.Cmd - StopDockerChrome now takes (t, debugPort) instead of (t, cmd, debugPort) This aligns with the latest lvt/testing package changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates all example test files to use the new lvt testing API, which changes how Docker Chrome is started and stopped in E2E tests. The API now returns an error directly from StartDockerChrome instead of returning a command object, and StopDockerChrome no longer requires the command object as a parameter.
- Updated API usage to handle error returns from
StartDockerChrome - Modified cleanup calls to
StopDockerChrometo use the new signature - Applied consistent error handling pattern across all affected test files
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| todos/todos_test.go | Updated Chrome container lifecycle management to use new API with error handling |
| counter/counter_test.go | Updated Chrome container lifecycle management to use new API with error handling |
| avatar-upload/avatar-upload_test.go | Updated Chrome container lifecycle management to use new API with error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Closing - this fix is not needed as the examples repo CI needs to use the pinned lvt version. The cross-repo test in livetemplate is a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update all examples to use the new lvt testing API:
StartDockerChromenow returnserrorinstead of*exec.CmdStopDockerChromenow takes(t, debugPort)instead of(t, cmd, debugPort)This aligns with the latest lvt/testing package changes and fixes the cross-repo test failures.
Files Changed
avatar-upload/avatar-upload_test.gocounter/counter_test.gotodos/todos_test.go🤖 Generated with Claude Code