Skip to content

fix: update to new lvt testing API#6

Closed
adnaan wants to merge 1 commit intomainfrom
fix/lvt-testing-api
Closed

fix: update to new lvt testing API#6
adnaan wants to merge 1 commit intomainfrom
fix/lvt-testing-api

Conversation

@adnaan
Copy link
Copy Markdown
Contributor

@adnaan adnaan commented Nov 29, 2025

Summary

Update all examples to use the new lvt testing API:

  • StartDockerChrome now returns error instead of *exec.Cmd
  • StopDockerChrome now takes (t, debugPort) instead of (t, cmd, debugPort)

This aligns with the latest lvt/testing package changes and fixes the cross-repo test failures.

Files Changed

  • avatar-upload/avatar-upload_test.go
  • counter/counter_test.go
  • todos/todos_test.go

🤖 Generated with Claude Code

Update all examples to use the new lvt testing API:
- StartDockerChrome now returns error instead of *exec.Cmd
- StopDockerChrome now takes (t, debugPort) instead of (t, cmd, debugPort)

This aligns with the latest lvt/testing package changes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings November 29, 2025 23:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates all example test files to use the new lvt testing API, which changes how Docker Chrome is started and stopped in E2E tests. The API now returns an error directly from StartDockerChrome instead of returning a command object, and StopDockerChrome no longer requires the command object as a parameter.

  • Updated API usage to handle error returns from StartDockerChrome
  • Modified cleanup calls to StopDockerChrome to use the new signature
  • Applied consistent error handling pattern across all affected test files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
todos/todos_test.go Updated Chrome container lifecycle management to use new API with error handling
counter/counter_test.go Updated Chrome container lifecycle management to use new API with error handling
avatar-upload/avatar-upload_test.go Updated Chrome container lifecycle management to use new API with error handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adnaan
Copy link
Copy Markdown
Contributor Author

adnaan commented Nov 29, 2025

Closing - this fix is not needed as the examples repo CI needs to use the pinned lvt version. The cross-repo test in livetemplate is a separate issue.

@adnaan adnaan closed this Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants