Skip to content

[Driver][SYCL] Update SYCL runtime library name and path for target-specific directories#21689

Closed
srividya-sundaram wants to merge 1 commit intointel:sycl-webfrom
srividya-sundaram:fix-lit-regressions
Closed

[Driver][SYCL] Update SYCL runtime library name and path for target-specific directories#21689
srividya-sundaram wants to merge 1 commit intointel:sycl-webfrom
srividya-sundaram:fix-lit-regressions

Conversation

@srividya-sundaram
Copy link
Copy Markdown
Contributor

This patch updates the Clang driver to support the renamed SYCL runtime library (libsycl.so → libLLVMSYCL.so) and its new location in target-specific directories. These changes align with PR #188770, which standardizes the SYCL runtime library naming and directory structure to match other LLVM runtime libraries.

Changes
Library Naming

  • Old: libsycl.so
  • New: libLLVMSYCL.so

Directory Structure
Both build and install directories now use target-specific subdirectories:

  • Old: lib/libsycl.so
  • New: lib/target-triple/libLLVMSYCL.so

For example, on x86_64-unknown-linux-gnu:

  • Old: build/lib/libsycl.so → install/lib/libsycl.so
  • New: build/lib/x86_64-unknown-linux-gnu/libLLVMSYCL.so → install/lib/x86_64-unknown-linux-gnu/libLLVMSYCL.so

Addresses LIT regressions.
cherry-pick of llvm/llvm-project#189053

@srividya-sundaram srividya-sundaram requested a review from jsji April 6, 2026 22:55
@srividya-sundaram srividya-sundaram marked this pull request as ready for review April 6, 2026 23:02
@srividya-sundaram srividya-sundaram requested a review from a team as a code owner April 6, 2026 23:02
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the library build been updated to generate the expected new library name?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on offline discussion with @jsji it was suggested that we revert llvm/llvm-project#189053 in the community as this needs to go together with Sergey's llvm/llvm-project#188770 , to avoid LIT test regressions and merge conflicts.
PR to revert: llvm/llvm-project#190715
Closing this PR.

Copy link
Copy Markdown
Contributor

@jsji jsji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit was already merged into sycl-web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants