TK-31: Add Automatic Group Creation for Information Sharing Agreements#36
Merged
klondikemarlen merged 16 commits intomainfrom Feb 12, 2026
Merged
TK-31: Add Automatic Group Creation for Information Sharing Agreements#36klondikemarlen merged 16 commits intomainfrom
klondikemarlen merged 16 commits intomainfrom
Conversation
…tory. Why? Makes factory more reusable.
Why? Vitest sometimes mangles names if resolution tree is complex. This prevents tests from failing when the table name is incorrectly inferred. Usually inferred as "_information_sharing_agreements" instead of "information_sharing_agreements".
Also add group destroy on ISA revert to draft.
Also fix some bugs in the implementation; sharing group is external.
All previous poolOptions are now top-level options. Please, refer to the migration guide: https://vitest.dev/guide/migration#pool-rework
…when running multiple files. Performance testing showed isolate true is ~17% faster than isolate false with vi.resetModules() (7.31s vs 8.86s). Alternative solution for isolate: false: - Add vi.resetModules() in beforeAll() hook in tests/setup.ts - See: https://vitest.dev/guide/migration#pool-rework
403e143 to
83a2415
Compare
Helps let AI Agents query database to find relevant info.
Why? I just wiped my database and don't want to re-enter test data manually. Also because I'm from Dawson.
Must use object as parameter.
…module import failures occur. Not sure if this is something that should only run in development?
…haring agreement. Pretty fatal bug, good thing I QA-ed properly.
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://yg-hpw.atlassian.net/browse/TK-31
References:
Context
Implements automatic group creation when information sharing agreements is marked as signed. Previously, groups had to be manually created and associated with agreements, which was error-prone and inconsistent. This change automates the entire process, ensuring proper group creation, admin assignment, and also cleanup if agreements are reverted to draft.
Implementation
Screenshots
N/A - backend changes only
Testing Instructions
dev test.dev up.Test Case 1: Signing an Agreement Creates Groups
Test Case 2: Reverting to Draft Destroys Groups