Merged
Conversation
Why? So that we can have a cleaner download pathway. See icefoganalytics/wrap@3f2d961
Why? So we can pass true/false values in form-data requests. See icefoganalytics/wrap@3f2d961#diff-0fe936fd4d154749955321539b9f7b1ff790e63901ed72c6cff673f0ccc0e7d9 Not sure I'm going to need this, but it's hard to remember so I'm pulling it in now.
Makes use of quickStartBufferStream from icefoganalytics/wrap@3f2d961
Previously was switching to "overlay" mode on medium screens.
…owser on sub-service failure.
…a-template-for-signature TK-22: Add Ability to Print ISA Acknowledgement Template for Signature
NOTE: in the future, this table might only hold metadata and a link to an Azure Blob Storage item.
Why? More flexible and scalable pattern.
In future will act as a link to Azure Blob Storage item.
Why? So we can have multiple has one attachments for the same target model.
Why? So we can link and attachment to the association that created it. This lets us have multiple has one associations on the same model.
In the future we might want to only rely on access grants once an ISA is signed (published), but that can wait until we are creating the access groups on ISA creation (see https://yg-hpw.atlassian.net/browse/TK-31)
Should be <Model>As<Format>
Why? v-file-input validation is not working as expected with "blur". Seems to always sort of sort of not error.
For whatever reason, the file input doesn't show a loading state when first opening, and it lags horribly. Now you at least get a loading state while waiting.
…-as-signed TK-25: Add Ability to Mark Information Sharing Agreements as Signed
…tory. Why? Makes factory more reusable.
Why? Vitest sometimes mangles names if resolution tree is complex. This prevents tests from failing when the table name is incorrectly inferred. Usually inferred as "_information_sharing_agreements" instead of "information_sharing_agreements".
Also add group destroy on ISA revert to draft.
Also fix some bugs in the implementation; sharing group is external.
All previous poolOptions are now top-level options. Please, refer to the migration guide: https://vitest.dev/guide/migration#pool-rework
…when running multiple files. Performance testing showed isolate true is ~17% faster than isolate false with vi.resetModules() (7.31s vs 8.86s). Alternative solution for isolate: false: - Add vi.resetModules() in beforeAll() hook in tests/setup.ts - See: https://vitest.dev/guide/migration#pool-rework
Helps let AI Agents query database to find relevant info.
Why? I just wiped my database and don't want to re-enter test data manually. Also because I'm from Dawson.
Must use object as parameter.
…module import failures occur. Not sure if this is something that should only run in development?
…haring agreement. Pretty fatal bug, good thing I QA-ed properly.
…ation TK-31: Add Automatic Group Creation for Information Sharing Agreements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes Merge Requests: