Skip to content

Fix unhandled exceptions in BrowserTabRouteDecisionHandler and SystemNavigationRouteDecisionHandler #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noah44846 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −7
Open

Fix unhandled exceptions in BrowserTabRouteDecisionHandler and SystemNavigationRouteDecisionHandler #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions ...-fragments/src/main/java/dev/hotwire/navigation/routing/BrowserTabRouteDecisionHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
package dev.hotwire.navigation.routing

import android.content.ActivityNotFoundException
import androidx.browser.customtabs.CustomTabColorSchemeParams
import androidx.browser.customtabs.CustomTabsIntent
import androidx.core.net.toUri
import com.google.android.material.R
import dev.hotwire.navigation.activities.HotwireActivity
import dev.hotwire.navigation.logging.logError
import dev.hotwire.navigation.navigator.NavigatorConfiguration
import dev.hotwire.navigation.util.colorFromThemeAttr

Expand Down Expand Up @@ -39,13 +41,17 @@ class BrowserTabRouteDecisionHandler : Router.RouteDecisionHandler {
.setNavigationBarColor(color)
.build()

CustomTabsIntent.Builder()
.setShowTitle(true)
.setShareState(CustomTabsIntent.SHARE_STATE_ON)
.setUrlBarHidingEnabled(false)
.setDefaultColorSchemeParams(colorParams)
.build()
.launchUrl(activity, location.toUri())
try {
CustomTabsIntent.Builder()
.setShowTitle(true)
.setShareState(CustomTabsIntent.SHARE_STATE_ON)
.setUrlBarHidingEnabled(false)
.setDefaultColorSchemeParams(colorParams)
.build()
.launchUrl(activity, location.toUri())
} catch (e: ActivityNotFoundException) {
logError("BrowserTabRouteDecisionHandler", e)
}

return Router.Decision.CANCEL
}
Expand Down
2 changes: 2 additions & 0 deletions ...ents/src/main/java/dev/hotwire/navigation/routing/SystemNavigationRouteDecisionHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ class SystemNavigationRouteDecisionHandler : Router.RouteDecisionHandler {
activity.startActivity(intent)
} catch (e: ActivityNotFoundException) {
logError("SystemNavigationRouteDecisionHandler", e)
} catch (e: SecurityException) {
logError("SystemNavigationRouteDecisionHandler", e)
}

return Router.Decision.CANCEL
Expand Down