Fix unhandled exceptions in BrowserTabRouteDecisionHandler and SystemNavigationRouteDecisionHandler#191
Open
noah44846 wants to merge 1 commit intohotwired:mainfrom
Conversation
BrowserTabRouteDecisionHandler: catch ActivityNotFoundException when no browser with Custom Tabs support is installed on the device. SystemNavigationRouteDecisionHandler: catch SecurityException in addition to the existing ActivityNotFoundException — thrown when the target activity is found but not accessible, e.g. android:exported="false" or a permission requirement the calling app does not satisfy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! We ran into two crashes in our production app that both stem from unhandled exceptions in route decision handlers. Sharing the stack traces below in case they're useful — happy to adjust anything if the fix looks different to you.
BrowserTabRouteDecisionHandlerthrowsActivityNotFoundExceptionwhenCustomTabsIntent.launchUrlfinds no browser with Custom Tabs support installed. This can happen on locked-down or minimal devices.SystemNavigationRouteDecisionHandleralready catchesActivityNotFoundException, but notSecurityException, which is thrown when the target activity exists but is not accessible — e.g.android:exported="false"or a permission requirement the calling app doesn't satisfy. This can happen with deep links targeting third-party apps with restricted activities.Both cases now log the error and return CANCEL instead of crashing.
Stack trace 1 — ActivityNotFoundException in BrowserTabRouteDecisionHandler:
Stack trace 2 — SecurityException in SystemNavigationRouteDecisionHandler: