Skip to content

Add Java options for a correct generation #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
disk91 wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add Java options for a correct generation #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ee0e9df
Add Java options for a correct generation
disk91 Mar 1, 2023
18de7e8
add proto used for poc_lora and change the package name
disk91 Mar 20, 2023
de2e728
Merge branch 'helium:master' into master
disk91 Mar 20, 2023
7a71918
Merge branch 'helium:master' into master
disk91 Apr 23, 2023
4cebb99
Merge branch 'helium:master' into master
disk91 May 11, 2023
dc10a8a
Merge branch 'helium:master' into master
disk91 Jun 16, 2023
1cf1519
Merge branch 'helium:master' into master
disk91 Jun 28, 2023
597e5e9
Merge branch 'helium:master' into master
disk91 Jul 9, 2023
5c81cfa
Merge branch 'helium:master' into master
disk91 Aug 20, 2023
0625b9c
add required Java options
disk91 Aug 20, 2023
43f62ba
Merge branch 'helium:master' into master
disk91 Sep 8, 2023
7594329
Merge branch 'helium:master' into master
disk91 Jan 30, 2024
1a8322a
Merge branch 'helium:master' into master
disk91 Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/blockchain_region_param_v1.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
syntax = "proto3";

package helium;
option java_package = "com.helium.grpc";
option java_outer_classname = "regionparam";
Copy link
Copy Markdown
Contributor

@jeffgrunewald jeffgrunewald Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regionparam and not RegionParam?

Copy link
Copy Markdown
Contributor

@jeffgrunewald jeffgrunewald Mar 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or IotRegionParam for consistency with the region.proto outer class name?

Copy link
Copy Markdown
Author

@disk91 disk91 Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the generation is not working properly when you name it correctly. I do not remind the detail of the problem but it was not working with camelcase and upfront uppercase

Copy link
Copy Markdown
Member

@madninja madninja May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how was the problem exhibited? At build time? If so, I would still like to see a CI step, just like we do for all other supported languages

option java_multiple_files = true;

message blockchain_region_params_v1 {
repeated blockchain_region_param_v1 region_params = 1;
Expand Down
3 changes: 3 additions & 0 deletions src/data_rate.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
syntax = "proto3";

package helium;
option java_package = "com.helium.grpc";
option java_outer_classname = "PocLoRa";
option java_multiple_files = true;

enum data_rate {
SF12BW125 = 0;
Expand Down
3 changes: 3 additions & 0 deletions src/region.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
syntax = "proto3";

package helium;
option java_package = "com.helium.grpc";
option java_outer_classname = "IotRegion";
option java_multiple_files = true;

enum region {
US915 = 0;
Expand Down
3 changes: 3 additions & 0 deletions src/service/iot_config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
syntax = "proto3";

package helium.iot_config;
option java_package = "com.helium.grpc";
option java_outer_classname = "IotConfig";
option java_multiple_files = true;

import "blockchain_region_param_v1.proto";
import "region.proto";
Expand Down
3 changes: 3 additions & 0 deletions src/service/packet_verifier.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
syntax = "proto3";

package helium.packet_verifier;
option java_package = "com.helium.grpc";
option java_outer_classname = "PacketVerifier";
option java_multiple_files = true;

message valid_packet {
uint32 payload_size = 1;
Expand Down
3 changes: 3 additions & 0 deletions src/service/poc_lora.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
syntax = "proto3";

package helium.poc_lora;
option java_package = "com.helium.grpc";
option java_outer_classname = "PocLoRa";
option java_multiple_files = true;

import "data_rate.proto";
import "service/packet_verifier.proto";
Expand Down