Add Java options for a correct generation#295
Conversation
madninja
left a comment
madninja
left a comment
There was a problem hiding this comment.
could you add a java CI build? That way we'll all know when stuff breaks
madninja
left a comment
madninja
left a comment
There was a problem hiding this comment.
One comment and I'd still like to see a Java CI step to ensure this does not break in future builds
src/blockchain_region_param_v1.proto
Outdated
| syntax = "proto3"; | ||
|
|
||
| package helium; | ||
| option java_package = "xyz.nova.grpc"; |
There was a problem hiding this comment.
can you rename this to com.helium.* please? This repo is in the foundation GitHub team
|
Hello, It has been updated and the new files with header have been added |
|
|
||
| package helium; | ||
| option java_package = "com.helium.grpc"; | ||
| option java_outer_classname = "regionparam"; |
There was a problem hiding this comment.
regionparam and not RegionParam?
There was a problem hiding this comment.
or IotRegionParam for consistency with the region.proto outer class name?
There was a problem hiding this comment.
Unfortunately, the generation is not working properly when you name it correctly. I do not remind the detail of the problem but it was not working with camelcase and upfront uppercase
There was a problem hiding this comment.
how was the problem exhibited? At build time? If so, I would still like to see a CI step, just like we do for all other supported languages
4 participants
These options helps to generate Java classes for Config service properly