Skip to content

ETT-1352 imgsrv/download/pdf should not output stack traces with a ba… #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moseshll merged 2 commits into from
Mar 18, 2026
Merged

ETT-1352 imgsrv/download/pdf should not output stack traces with a ba… #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cc3692
ETT-1352 imgsrv/download/pdf should not output stack traces with a ba…
moseshll Mar 13, 2026
e8d46e4
Update test URL to more realistic value based on reviewer feedback.
moseshll Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions imgsrv/lib/SRV/Utils.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,14 @@ sub parse_env {
} else {
$value = join(',', @values);
}
if ( ( $param eq 'seq' || $param eq 'seq[]' ) && ( $values[0] =~ m,^\d+$, || $values[0] =~ m{^\d+,\d+} || $values[0] =~ m{^\d+\-\d+} ) ) {
$value = "seq:" . join(',', sort { int($a) <=> int($b) } @values);
if ( $param eq 'seq' || $param eq 'seq[]' ) {
if ( $values[0] =~ m,^\d+$, || $values[0] =~ m{^\d+,\d+} || $values[0] =~ m{^\d+\-\d+} ) {
$value = "seq:" . join(',', sort { int($a) <=> int($b) } @values);
$key = 'file';
} else {
# Not a valid seq, remove it
next;
}
}
$$params{$key} = $value;
}
Expand Down
7 changes: 7 additions & 0 deletions pt/web/firebird/tests/imgsrv_download.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,11 @@ test.describe('imgsrv download', () => {
expect(downloadHeaders['content-type']).toEqual('image/jpeg');
expect(downloadBody.length).toBeGreaterThan(1);
});

test('download pdf with bogus seq', async ({ request, page }) => {
const initialResponse = await request.get(
'http://apache:8080/cgi/imgsrv/download/pdf?id=test.pd_open&attachment=1&tracker=D1&seq=mashed_potatoes'
);
expect(initialResponse.status()).toEqual(200);
});
});
Loading