ETT-1352 imgsrv/download/pdf should not output stack traces with a ba…#195
Merged
ETT-1352 imgsrv/download/pdf should not output stack traces with a ba…#195
Conversation
…d seq - Remove imgsrv `seq` parameters that do not conform to \d+, \d+-\d+, or \d+,\d+... - Add superficial playwright test against example which previously would produce a 500 error
Member
|
That playwright test is small but fine! I tested current behavior vs this change (with just the bad |
carylwyatt
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d seq
seqparameters that do not conform to \d+, \d+-\d+, or \d+,\d+...@carylwyatt if you would critique the Playwright side, that was a semi-sloppy afterthought and probably could be done better.