Open
Conversation
chunloklo
requested review from
chsahit,
irapha and
joshuamorton
as code owners
irapha
approved these changes
Oct 3, 2017
Member
|
Apparently I added a bug in pyrostest if someone wants to fix: https://github.com/gtagency/pyrostest/blob/master/pyrostest/ros_test.py#L155, .format should be inside the parens. It also might be worth formatting rosmaster_uri too. Rapha or I will need to push the new version before it gets reflected in the cbuild here. That's also not why the build is failing, but its also happening. |
joshuamorton
reviewed
Oct 3, 2017
Member
joshuamorton
left a comment
joshuamorton
left a comment
There was a problem hiding this comment.
LGTM. Might want to add this as an alias?
joshuamorton
approved these changes
Oct 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.