Open
Conversation
hartikainen
commented
Aug 11, 2025
| LOCAL_GPU = 100006 | ||
| P4 = 21 | ||
| T4 = 22 | ||
| L4 = 11 |
Author
There was a problem hiding this comment.
I'm not sure what this value should be.
There was a problem hiding this comment.
Since we already have L4_24TH = 68 which refers to the same GPU family, adding a separate L4 = 11 might create confusion. To keep the resource definitions clear and avoid ambiguity, I suggest we remove the new L4 entry and exclusively use L4_24TH when referring to L4 GPUs. The logic in vertex.py can then be simplified to handle just the one L4_24TH type, which it correctly maps to 'NVIDIA_L4'.
This would also resolve the uncertainty around what value L4 should have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.