Fix Issue 57: Add support for L4 GPUs in Vertex jobs#62
Open
tripathiji1312 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix Issue 57: Add support for L4 GPUs in Vertex jobs#62tripathiji1312 wants to merge 1 commit intogoogle-deepmind:mainfrom
tripathiji1312 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
…t corresponding unit test
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
You might be interested in #58. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #57 by adding support for L4 GPUs when launching jobs on Vertex AI.
Description
Currently, attempting to use an L4 GPU by specifying L4_24TH in
xm.JobRequirementsresults in a KeyError: 'NVIDIA_TESLA_L4_24TH'. This is because the accelerator type was being constructed by prefixing the resource name with NVIDIA_TESLA_, which is not the correct identifier for L4 GPUs on Vertex AI. The correct accelerator type is NVIDIA_L4.This change updates
vertex.pyto special-case the L4_24TH GPU type and use the correct NVIDIA_L4 accelerator name. A corresponding unit test has been added tovertex_test.pyto verify the fix and prevent future regressions.Changes
Modified
vertex.pyto correctly handle the L4 GPU accelerator type.Added test_get_machine_spec_l4 to
vertex_test.pyto ensure L4 GPUs are correctly configured