Skip to content

Update FDC emulator to v3.3.4 #10278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fredzqm wants to merge 1 commit into from
+2 −0
Closed

Update FDC emulator to v3.3.4 #10278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
- Updated the Firebase Data Connect local toolkit to v3.3.4, which includes the following changes:
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request title and this changelog entry indicate an update to the Firebase Data Connect local toolkit to v3.3.4, but the actual code changes (e.g., version bump in package.json or a version constant file) are missing from this PR.

Additionally, the PR description is empty, which violates the repository style guide requiring ### Description, ### Scenarios Tested, and ### Sample Commands.

References
  1. The repository style guide requires PR descriptions to include specific sections like Description, Scenarios Tested, and Sample Commands to provide context and verification of changes. (link)

- [fixed] Fixed an issue where Angular SDK generation would fail.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrasing [fixed] Fixed is redundant and inconsistent with the existing changelog entries. Furthermore, if this update introduces a new angularSdk target, please verify if src/commands/dataconnect-sdk-generate.ts needs to be updated to include it in the loadAllWithSDKs filter, as it currently only checks for other SDK types.

Suggested change
- [fixed] Fixed an issue where Angular SDK generation would fail.
- Fixed an issue where Angular SDK generation would fail.

- Fixed an issue where functions deployments would silently fail (#6989)
Loading